Skip to content

BK-2393 Remove deprecated button and import template - #815

Merged
ride90 merged 2 commits into
booktype:masterfrom
danielhjames:BK-2393
Dec 11, 2017
Merged

BK-2393 Remove deprecated button and import template#815
ride90 merged 2 commits into
booktype:masterfrom
danielhjames:BK-2393

Conversation

@danielhjames

Copy link
Copy Markdown
Contributor

Because the Create New Book dialogue now handles imports much better.

Also, uncommenting the 'Show in a list' option which we now have space for again, because users with lots of books on their Dashboard were missing that feature.

@ride90

ride90 commented Dec 8, 2017

Copy link
Copy Markdown
Member

Hi @danielhjames ,
This PR will throw error if you visit page "/accounts/username/".
Booktype/lib/booktype/apps/account/templates/account/dashboard.html includes account/dashboard_import_book_modal.html inside (line 210).
Please, fix it and update pr.

@danielhjames

Copy link
Copy Markdown
Contributor Author

Thanks for catching that @ride90 , I did not experience this on the airr site as I had left the old template in place. Template has been updated in a new commit.

@ride90
ride90 merged commit 16403ad into booktype:master Dec 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants