Add a failWhenUndefined option to the SchemaBasedCondition

[clemens-msupply]

This PR adds an option to mark the scope of a rule condition as required.

The original proposed solution was to add:
whenUndefined: 'fail' | 'success'
but after understanding the problem a bit better I think the main problem is that you can't define the condition scope as required and adding this option keeps it a bit closer to JSONSchema.

I added a comment about my interpretation about whats happening in the code. Let me know what you think, I might be wrong about it and AJV just does something weird... I also still like whenUndefined since it might actually be more user friendly.

Original discussion:
https://jsonforms.discourse.group/t/no-rule-validation-for-array-contains-value-when-array-undefined/1308/7

[netlify]

✅ Deploy Preview for jsonforms-examples ready!

Name	Link
🔨 Latest commit	8fe5fca
🔍 Latest deploy log	https://app.netlify.com/sites/jsonforms-examples/deploys/650dae700959530008ac33bc
😎 Deploy Preview	https://deploy-preview-2095--jsonforms-examples.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[sdirix]

Thanks for the contribution ❤️

I'll talk with the team in regards whether we prefer whenUndefined or scopeRequired 👍.

What I don't understand is your comment in the discussion board where the reverse effect and condition did not work for you, i.e.

am pretty sure I tried the reverse rule and it didn’t work for me

Looking at the code here and the suggested improvements of scopeRequired only applying in the true case, this seems for me to indicate that reversing the effect/rule for the undefined case should also have worked. Can you verify what's going on?

[coveralls]

coverage: 84.469%. remained the same when pulling 8fe5fca on clemens-msupply:rules-required-scope into 29e42b7 on eclipsesource:master.

Accidentally approved the wrong PR

[clemens-msupply]

I created some examples for the "range" rule and the "array contains" rule:

https://github.com/clemens-msupply/jsonforms-react-seed/tree/rule-condition-with-undefined-values

I reversed the rule by using "not" but it both behaves the same (dependent controls are showing on initial load). Is this what you meant?

[sdirix]

Heads up: We'll take a look at this again soon

[FedeTommi]

I created some examples for the "range" rule and the "array contains" rule:

https://github.com/clemens-msupply/jsonforms-react-seed/tree/rule-condition-with-undefined-values

I reversed the rule by using "not" but it both behaves the same (dependent controls are showing on initial load). Is this what you meant?

Hi there, I experienced the same issue here https://jsonforms.discourse.group/t/default-hide-for-array-contains-value-when-array-undefined/2152. Are there any updates on this?

[sdirix]

I answered in the community thread 👍