Skip to content

feat: remove state slice when set as undefined - #2163

Merged
sdirix merged 7 commits into
eclipsesource:masterfrom
JBBianchi:delete-on-set-undefined
Jul 13, 2023
Merged

feat: remove state slice when set as undefined#2163
sdirix merged 7 commits into
eclipsesource:masterfrom
JBBianchi:delete-on-set-undefined

Conversation

@JBBianchi

Copy link
Copy Markdown
Contributor

Handles setting a slice state to undefined as removing the said slice.

Related to #1790

@netlify

netlify Bot commented Jul 12, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 041db92
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64b00e5fb213410008cbc85b
😎 Deploy Preview https://deploy-preview-2163--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution ❤️

Please add test cases for the new behavior and make sure that the builds are green.

@JBBianchi

Copy link
Copy Markdown
Contributor Author

Sorry, I did hammer a bit the CI, I don't have the environment installed locally so I could test before committing.

I hope it's good enough.

Comment thread packages/core/test/reducers/core.test.ts Outdated
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 84.254%. remained the same when pulling 041db92 on JBBianchi:delete-on-set-undefined into 9acbbab on eclipsesource:master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

@sdirix
sdirix merged commit d6f1fda into eclipsesource:master Jul 13, 2023
@sdirix

sdirix commented Jul 13, 2023

Copy link
Copy Markdown
Member

We can do an alpha release soon, so you can consume the changes 👍

@JBBianchi

Copy link
Copy Markdown
Contributor Author

We can do an alpha release soon, so you can consume the changes 👍

That'd be great :)

@sdirix

sdirix commented Jul 24, 2023

Copy link
Copy Markdown
Member

@JBBianchi 3.1.1-alpha.0 is released

@JBBianchi
JBBianchi deleted the delete-on-set-undefined branch August 2, 2023 12:44
@JBBianchi

Copy link
Copy Markdown
Contributor Author

This feature seems to work as expected but this alpha-0 ships the bug reported (and fixed) in #2166 so I'll wait next release to actually use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Difference in mapAdditionalProps props.data and global data when setting a prop as undefined via handleChange

4 participants