Skip to content

ci: Enable and fix tests on MacOS - #2171

Merged
sdirix merged 2 commits into
masterfrom
2159-mac-tests
Aug 16, 2023
Merged

ci: Enable and fix tests on MacOS#2171
sdirix merged 2 commits into
masterfrom
2159-mac-tests

Conversation

@lucas-koehler

@lucas-koehler lucas-koehler commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

For ava tests, register ts-node with adapted typescript config adaptions via a javascript file. Before, the typescript config adaptions were loaded via an environment variable not working on mac and Windows via one configuration.

With this, the cross-env dev dependency is obsolete in core and angular packages. This removes the deps and regenerates the lock file to update dependencies.

Fixes #2159

@netlify

netlify Bot commented Aug 11, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 7843238
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64d63f678a74f6000805819f
😎 Deploy Preview https://deploy-preview-2171--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

coveralls commented Aug 11, 2023

Copy link
Copy Markdown

Coverage Status

coverage: 84.469%. remained the same when pulling 7843238 on 2159-mac-tests into e685ae8 on master.

For ava tests, register ts-node with adapted typescript config adaptions
via a javascript file. Before, the typescript config adaptions were
loaded via an environment variable not working on mac and Windows
via one configuration.
- Remove cross-env dev dependency from core and angular
- Recreate pnpm lock file to update dependencies
@lucas-koehler
lucas-koehler marked this pull request as ready for review August 11, 2023 15:07
@lucas-koehler
lucas-koehler requested a review from sdirix August 11, 2023 15:08

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@sdirix
sdirix merged commit 3e5f46f into master Aug 16, 2023
@sdirix
sdirix deleted the 2159-mac-tests branch August 16, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix tests on macOS and execute during CI

3 participants