Skip to content

core: fix removeItems for list renderers - #2181

Merged
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
xou816:fix-2180
Oct 4, 2023
Merged

core: fix removeItems for list renderers#2181
lucas-koehler merged 1 commit into
eclipsesource:masterfrom
xou816:fix-2180

Conversation

@xou816

@xou816 xou816 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Fixes #2180

@CLAassistant

CLAassistant commented Sep 29, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@netlify

netlify Bot commented Sep 29, 2023

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 29be9cb
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/65170f74dc930700080500b4
😎 Deploy Preview https://deploy-preview-2181--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler
lucas-koehler self-requested a review October 4, 2023 10:27
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 84.469%. remained the same when pulling 29be9cb on xou816:fix-2180 into 8fc90d3 on eclipsesource:master.

@lucas-koehler lucas-koehler left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xou816 ,
thanks for contributing this fix and opening the corresponding issue ❤️
The changes look good to me!

@lucas-koehler
lucas-koehler merged commit 28eeeca into eclipsesource:master Oct 4, 2023
@xou816

xou816 commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

You're welcome! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

List renderer HOC: removeItems does not handle indices above 10 properly

4 participants