Make material renderers aware of input variant in theme - #2182
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0c5f106 to
38fc730
Compare
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @sebastianfrey
Thank you very much for the contribution ❤️
The changes already look pretty good to me and worked well in the example app!
Besides the small remarks inline, I have one question:
Could we make handing in InputComponent to the controls optional and fall back to material's Input? With this, we would not break custom renderers that use these controls. Do you think that makes sense?
|
Hi @lucas-koehler,
Let me know if anything else is missing. |
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @sebastianfrey
Thank you for the updates! I have just one remaining small comment inline.
1ad814e to
67cf64e
Compare
|
Hi @lucas-koehler, Your requested change should be fixed now. After browsing through the example forms, I have noticed that |
lucas-koehler
left a comment
There was a problem hiding this comment.
LGTM now. Thanks again for the contribution and the updates :)
|
Hi @lucas-koehler, Is there the possibility to publish a pre-release version for this PR? |
|
Hi @sebastianfrey , |
|
@lucas-koehler Ok thanks, no rush here please! |
|
Hi @sebastianfrey , we released |
|
@lucas-koehler Thank you very much! |
|
@lucas-koehler do you have an ETA for the |
|
Hi @MikeyZat , our current plan is to publish a |
Resolves #1797.
This PR makes material renderers aware of the input variant defined in the global MUI theme.
The example app was enhanced with a select, which allows to change the input variant.