Allow the translation of the No Data case for MaterialArrayLayout - #2286
Merged
sdirix merged 3 commits intoFeb 20, 2024
Merged
Conversation
|
|
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Hi @Maxouwell , thanks for the PR ❤️ We'll have a look soon. |
sdirix
approved these changes
Feb 19, 2024
sdirix
left a comment
sdirix
left a comment
Member
There was a problem hiding this comment.
Looks good! Thanks for the contribution ❤️
Member
|
@Maxouwell There is still some type error in the test, can you take a look? |
Contributor
Author
|
Lookink into it |
Contributor
Author
|
I can't reproduct the error on my side, I explicitly made the empty test array data an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative PR for #2285