chore: remove 'matchMedia' mock - #2370
Merged
Merged
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
approved these changes
Aug 28, 2024
lucas-koehler
left a comment
lucas-koehler
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the cleanup ✨
The 'matchMedia' mock was previously introduced to workaround the 'Hidden' component of Material UI not rendering in case media queries are not available in the environment. With JSON Forms 3.3.0 we removed all usages of the 'Hidden' component so the 'matchMedia' mock is also no longer required.
sdirix
force-pushed
the
remove-matchmedia-mock
branch
from
August 28, 2024 14:43
8baefa6 to
a23e990
Compare
Member
Author
|
I rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'matchMedia' mock was previously introduced to workaround the 'Hidden' component of Material UI not rendering in case media queries are not available in the environment.
With JSON Forms 3.3.0 we removed all usages of the 'Hidden' component so the 'matchMedia' mock is also no longer required.