Skip to content

refactor(material-renderers): flushable debounce - #2440

Merged
sdirix merged 9 commits into
eclipsesource:masterfrom
johannesss:flushable-debounce
May 26, 2025
Merged

refactor(material-renderers): flushable debounce#2440
sdirix merged 9 commits into
eclipsesource:masterfrom
johannesss:flushable-debounce

Conversation

@johannesss

Copy link
Copy Markdown
Contributor

this is just a poc to see if this path is viable

fixes #2260

this is just a poc to see if this path is viable
@netlify

netlify Bot commented Apr 15, 2025

Copy link
Copy Markdown

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 4d4fca1
🔍 Latest deploy log https://app.netlify.com/projects/jsonforms-examples/deploys/68304b4ba24b9300084b1b87
😎 Deploy Preview https://deploy-preview-2440--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@johannesss
johannesss marked this pull request as draft April 16, 2025 06:14
@johannesss
johannesss marked this pull request as ready for review April 16, 2025 06:59
@coveralls

coveralls commented Apr 16, 2025

Copy link
Copy Markdown

Coverage Status

coverage: 82.521% (+0.004%) from 82.517%
when pulling 4d4fca1 on johannesss:flushable-debounce
into 393c4dc on eclipsesource:master.

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually this makes sense to me. In which state is the PR now, shall we do a detailed review before you continue?

@johannesss

Copy link
Copy Markdown
Contributor Author

Conceptually this makes sense to me. In which state is the PR now, shall we do a detailed review before you continue?

Yes, sure!

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I just have a minor change request

Comment thread packages/material-renderers/src/util/debounce.ts Outdated

@sdirix sdirix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks for the contribution ❤️

@sdirix
sdirix merged commit f3e9a7a into eclipsesource:master May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unpredictable data change

3 participants