[BUGFIX lts] Update ApplicationInstance#visit to use followRedirects() - #20574
Conversation
d364d09 to
7fa758a
Compare
|
The router.js fix has finally landed. I've pushed the version update to this branch as well. |
|
Is anything blocking this? |
|
Tests were failing and it has not been updated since |
|
Would it be possible to move forward with this PR please? Thank you. |
|
@MrChocolatine we're mid pulling router_js in to the repo: #21211 which would include any changes to router_js, and then this PR becomes very tiny!! 🎉 |
|
@NullVoxPopuli , that's great. Once #21211 is merged, do you know for which version it will be available? Eventually backported to previous 6.x versions? |
|
if it merged nowish, it'd be in 6.12 LTS, but if it merges after 6.12 is out, it'd go in to 7 -- personally, I'd like to even delay the 6.12 release so we can get more bugfixes in -- the community has blessed us with so many bugfixes the last few weeks <3 |
|
I do agree, I think bug fixes are more important. |
|
If it merged now, it would be in 7.0 We're not delaying releases. The the point of a release train is that there are always more releases. Anything important enough will be backported. |
|
gotchya -- I feel like I need a app/dashboard for our release train 🙈 haha |
|
In v7, oh okay. emberjs/ember-test-helpers#332 exists since 2018, and this fix (this PR) since 2023. It would have been great to make it available for all the versions since 2023... |
|
@davidtaylorhq Any interest in rebasing? If we merge before the router is inlined (asap), this is more easily backported. |
The current implementation of `Transition#followRedirects()` is identical to the logic here: it catches rejections, and then checks for any other `activeTransition`. Therefore, this commit introduces no change in behavior. But, if/when emberjs/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.
7fa758a to
dde8702
Compare
kategengler
changed the title
|
Yey, thanks everyone. |
|
@MrChocolatine If you have a chance, can you try canary and validate that it fixes that test helpers bug for you? |
6 participants
The current implementation of
Transition#followRedirects()is identical to the logic here: it catches rejections, and then checks for any otheractiveTransition. Therefore, this commit introduces no change in behavior.But, if/when emberjs/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.