Get @glimmer/syntax publishable again and get some smoke tests going for prettier - #21188
Merged
Conversation
Contributor
📊 Package size report -0%↓
🤖 This report was automatically generated by pkg-size-action |
fisker
reviewed
Mar 4, 2026
NullVoxPopuli
force-pushed
the
nvp/prettier-smoke-tests
branch
from
March 5, 2026 21:13
c7c0bc8 to
6b70b33
Compare
NullVoxPopuli
marked this pull request as ready for review
March 5, 2026 22:19
kategengler
reviewed
Mar 5, 2026
| "@ember/template-compiler/lib/-internal/primitives.js": "ember-source/@ember/template-compiler/lib/-internal/primitives.js", | ||
| "@ember/template-compiler/lib/compile-options.js": "ember-source/@ember/template-compiler/lib/compile-options.js", | ||
| "@ember/template-compiler/lib/dasherize-component-name.js": "ember-source/@ember/template-compiler/lib/dasherize-component-name.js", | ||
| "@ember/template-compiler/lib/plugins/allowed-globals.js": "ember-source/@ember/template-compiler/lib/plugins/allowed-globals.js", |
Contributor
Author
There was a problem hiding this comment.
yea, it should have been on main -- we should probably have a lint that catches this
kategengler
approved these changes
Mar 5, 2026
Contributor
|
@NullVoxPopuli There never been a new release after this PR get merged, is it because no changes has been made, or this doesn't work? Just checking. |
Contributor
Author
|
@fisker thanks for reminding me! I totally forgot (sorry!) I've started the process of unblocking this with release-plan/release-plan#247 (our org's main release automation for most things that aren't releasing ember-source) |
This was referenced Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From @fisker's comments here: glimmerjs/glimmer-vm#1689 (very helpful! <3 )
This PR:
@glimmer/syntaxfor publishing -- only supporting node environments for now@glimmer/syntaxis used by prettier, ember-template-recast, and more@glimmer/componentis published, is how we'd publish@glimmer/syntax