Skip to content

Incorrect return and data type in license api #4296

Description

@s4mur4i

While developing for api endpoint /manage/v1/config/license we detected 2 issues, which are not consistent with api docs
https://docs.github.com/en/enterprise-server@3.19/rest/enterprise-admin/manage-ghes?apiVersion=2022-11-28#get-the-enterprise-license-information. We opened support case, and verified with github support our findings.

  1. The response is advertised as: [{...}] but actual response is {...}
  2. supportKey is actual a bool return.

Example response:
curl -u api_key:xxxx https://hostname:8443/manage/v1/config/license
{"advancedSecurityEnabled":false, "advancedSecuritySeats":0, "clusterSupport":false, "company":"yes", "croquetSupport":true, "customTerms":false, "evaluation":false, "expireAt":"2029-01-01T07:59:59Z", "insightsEnabled":false, "insightsExpireAt":"0001-01-01T00:00:00Z", "learningLabEvaluationExpires":"0001-01-01T00:00:00Z", "learningLabSeats":0, "perpetual":false, "referenceNumber":"zyz", "seats":100, "sshAllowed":true, "supportKey":false, "unlimitedSeating":false}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions