Skip to content

fix(java-sql): temp fix for lint and skip generate - #14005

Merged
lqiu96 merged 3 commits into
googleapis:mainfrom
zhumin8:skip-sql
Aug 26, 2026
Merged

fix(java-sql): temp fix for lint and skip generate#14005
lqiu96 merged 3 commits into
googleapis:mainfrom
zhumin8:skip-sql

Conversation

@zhumin8

@zhumin8 zhumin8 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Temp fix for lint issue and skip generate to avoid this overriden by generation run.

This is a temporarily solution to unblock development (e.g., #13928), while we figure out a longer term solution.

For googleapis/librarian#7146

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 6, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up extra blank lines in several Java gRPC service files and configures skip_generate: true for the Java library in librarian.yaml. There are no review comments, so I have no feedback to provide.

@zhumin8 zhumin8 mentioned this pull request Aug 6, 2026
Open
@zhumin8
zhumin8 marked this pull request as ready for review August 6, 2026 07:53
@zhumin8
zhumin8 requested review from a team as code owners August 6, 2026 07:53
blakeli0
blakeli0 reviewed Aug 6, 2026
View reviewed changes
Comment thread librarian.yaml
- path: google/cloud/location/locations.proto
java:
released_version: 0.1.0
skip_generate: true

@blakeli0 blakeli0 Aug 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean this library will not be regenerated when we run librarian generate?

@JoeWang1127 JoeWang1127 Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@lqiu96 lqiu96 Aug 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blakeli0 Do you have any concerns if we are able to temporarily not generate this library?

We can re-enable this when the platform team is able to create the temp workaround

@lqiu96
lqiu96 enabled auto-merge (squash) August 26, 2026 16:03
@lqiu96
lqiu96 merged commit b6f73db into googleapis:main Aug 26, 2026
197 checks passed
This was referenced Sep 4, 2026
Closed
Merged
lqiu96 pushed a commit that referenced this pull request Sep 4, 2026
@release-please
chore(main): release 1.91.0 (#14271)
0b2991e 
🤖 I have created a release *beep* *boop*
---


<details><summary>1.91.0</summary>

##
[1.91.0](v1.90.0...v1.91.0)
(2026-09-04)


### ⚠ BREAKING CHANGES

* **datalabeling:** remove java-datalabeling library
([#14189](#14189))
* **datacatalog:** remove java-datacatalog library
([#14178](#14178))

### Features

* **apptopology:** onboard a new library
([#14204](#14204))
([f871a07](f871a07))
* **bigtable:** Option to disable direct access fallback
([#14193](#14193))
([5b6a974](5b6a974))
* **datacatalog:** remove java-datacatalog library
([#14178](#14178))
([2910f63](2910f63))
* **datalabeling:** remove java-datalabeling library
([#14189](#14189))
([334d35a](334d35a)),
refs
[#14176](#14176)
* **gax:** add getSingleHeader to HttpHeadersUtils
([#14137](#14137))
([f114422](f114422))
* **gax:** add ResumableUploadClient.startUpload() and supporting types
([#14138](#14138))
([d7e2be2](d7e2be2))
* **gax:** add ResumableUploadResponseParser
([#14135](#14135))
([e1a0b17](e1a0b17))
* **gax:** allow non-JSON HttpContent and absolute request URLs in
HttpRequestRunnable
([#14134](#14134))
([ac4a49a](ac4a49a))
* **gax:** implement queryStatusCallable for resumable uploads
([#14155](#14155))
([67719c0](67719c0))
* **gax:** implement startUploadCallable for resumable uploads
([#14139](#14139))
([4e65b6c](4e65b6c))
* **gax:** implement uploadChunkCallable for resumable uploads
([#14140](#14140))
([1c643de](1c643de))
* **google/shopping/merchant/loyaltycustomers/v1:** onboard new library
([#14257](#14257))
([590a51c](590a51c))
* **grpc-gcp:** drain scaled-down channels
([#14216](#14216))
([bbbd18c](bbbd18c))
* **grpc-gcp:** move scale-up to background worker
([#14206](#14206))
([41f0a2e](41f0a2e))
* **grpc-gcp:** penalize retryable channel errors
([#14219](#14219))
([829872e](829872e))
* **grpc-gcp:** prime scaled channels before publish
([#14232](#14232))
([dd75645](dd75645))
* **spanner:** add client-level CallContextConfigurator to
SpannerOptions
([#14256](#14256))
([eef74d2](eef74d2))
* **spanner:** prime scaled-up dynamic channel pool channels with SELECT
1
([#14254](#14254))
([4d26645](4d26645))


### Bug Fixes

* **auth:** refine JSpecify nullability annotations for external account
credentials
([#14164](#14164))
([385e1f2](385e1f2))
* **bigquery-jdbc:** resolve `statementType` via `getJob` fallback to
avoid post-execution dry run for DDL
([#14265](#14265))
([d38d9f0](d38d9f0))
* **bigtable:** truncate client generated timestamps on the emulator c…
([#14234](#14234))
([94e680f](94e680f))
* **gax:** propagate structured LRO error details to ApiException
([#14022](#14022))
([865a15b](865a15b))
* **grpc-gcp:** correct channel lifecycle bookkeeping
([#14196](#14196))
([3df32ba](3df32ba))
* **grpc-gcp:** prevent hot-channel skew
([#14198](#14198))
([07a7505](07a7505))
* **java-sql:** temp fix for lint and skip generate
([#14005](#14005))
([b6f73db](b6f73db))
* **spanner:** prioritize leader replica for read-write transactions in
location-aware routing
([#14195](#14195))
([6383f81](6383f81))
* **spanner:** route ExecuteBatchDml through transaction affinity
endpoint
([#14192](#14192))
([5e9e3cd](5e9e3cd))
* **storage:** resolve GraalVM Native Image test failure for
java-storage
([#14226](#14226))
([93e0920](93e0920))


### Performance Improvements

* **bigquery-jdbc:** eliminate sync getJob RPC call
([#14197](#14197))
([ccf12b0](ccf12b0))
* **ci:** replace mvn help:evaluate with native bash and sed extraction
([#14218](#14218))
([744a522](744a522))


### Dependencies

* Upgrade grpc-java to 1.83.0
([#13967](#13967))
([0cdc695](0cdc695))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 left review comments
@lqiu96 lqiu96 lqiu96 left review comments
@JoeWang1127 JoeWang1127 JoeWang1127 approved these changes
+2 more reviewers
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
@nnicolee nnicolee nnicolee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhumin8 @blakeli0 @lqiu96 @nnicolee @JoeWang1127