Skip to content

Remove datastore.key._dataset_ids_equal and just use string equality check #821

Description

@dhermes

See #528 for some history here.

The issue is that requests made using foo instead of s~foo fail in strange ways.

So as a result we have to use datastore.helpers._prepare_key_for_request to strip dataset IDs from keys that get sent to the server. This has accidental caused bugs in the past (e.g. allowing keys from a different dataset bar to be inserted into dataset foo)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the Datastore API.priority: p2Moderately-important priority. Fix may not be included in next release.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions