test(spec): verify portable parser settings - #1053
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
a46ac8b to
b3b6e3f
Compare
b3b6e3f to
22cbfcc
Compare
22cbfcc to
40b369d
Compare
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Low Risk
Test-only changes and a dev-dependency; no production parsing or spec behavior is modified.
Overview
Adds an integration test on the
usage-rsfacade that derive-emitted KDL keeps parser settings such asunknown_flags = "error"as portable spec metadata, not just runtime behavior.The test defines a strict CLI (
StrictEx), asserts unknown flags fail at parse time, checks the generated KDL includesunknown_flags "error", and round-trips that KDL throughusage-libto confirmSpec.unknown_flagsisError.usage-libis wired in as a dev-dependency only for this assertion.Reviewed by Cursor Bugbot for commit 40b369d. Bugbot is set up for automated code reviews on this repo. Configure here.