test(parse): add clap micro-conformance - #1133
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8f532f4 to
8a80244
Compare
8a80244 to
b0fe19b
Compare
b0fe19b to
71a0447
Compare
71a0447 to
75b4b8e
Compare
Instruction countsThe comparison never ran — an earlier step failed.
|
75b4b8e to
ee98508
Compare
|
Addressed in the owning PR: missing-argument help now selects ANSI color from stderr, while ordinary help continues to inspect stdout. I also fixed the fleet failure this conformance work exposed by rendering This comment was generated by Codex. |
ee98508 to
9bd5c79
Compare
|
Addressed in #1133: reference documentation now uses This comment was generated by Codex. |
9bd5c79 to
e6d34d4
Compare
e6d34d4 to
561ab79
Compare
37014ac to
fad90db
Compare
fad90db to
c7bc4fd
Compare
c7bc4fd to
5154820
Compare
2d62c65 to
68f9e97
Compare
68f9e97 to
231c309
Compare
231c309 to
668ceaa
Compare
668ceaa to
b8074c2
Compare
b8074c2 to
9e43fe7
Compare
9e43fe7 to
99d6539
Compare
99d6539 to
a4a3172
Compare
a4a3172 to
3644e72
Compare
3644e72 to
126c975
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 126c975. Configure here.
2fee415 to
e463883
Compare
e463883 to
c9a0804
Compare
c9a0804 to
271fdb1
Compare

Summary
require_equals=in typed help placeholdersThis establishes the executable harness for the larger generated micro-conformance PLAN item; later stack PRs can add matrix rows without mixing harness design into every feature test.
Validation
cargo test -p usage-conformance --test clap_micro --all-featurescargo test -p usage-argv --all-featurescargo clippy --workspace --all-features --all-targets -- -D warningsThis PR was generated by Codex.
Note
Medium Risk
Changes the public parse-error enum and help/spec usage rendering, which can break embedders that treated empty-argv help as
Error::Help. Behavior is test-covered but is a user-visible CLI contract change.Overview
Adds a paired clap/usage typed-CLI harness (
clap_micro) that compares accepted argv, typed values, error kinds, exit status/stream, help, and version for the first matrix rows (require_equals, defaults, delimiters, hyphen/negative values, enums, arity, globals, groups, external subcommands, and command policies).Splits
arg_required_else_helpintoError::MissingArgsHelpso generatedparse()prints short help to stderr and exits 2, matching clap, instead of treating it as an explicit help request.Aligns
require_equalspresentation: missing-value diagnostics now say an equals is required, and help/spec usage render--flag=<VAL>/--flag[=VAL], including round-trip parsing of those forms.Reviewed by Cursor Bugbot for commit 271fdb1. Bugbot is set up for automated code reviews on this repo. Configure here.