fix(spec): avoid inferred metadata from included specs

[jdx]

Summary

• keep filename-derived name and bin metadata limited to the top-level spec
• parse included fragments without inferring metadata from their filenames
• remove the unreachable missing-name lint and accept omitted metadata consistently for files and stdin
• add regression coverage for both behaviors

Root cause

Spec::parse_file() intentionally derives a missing bin from the filename and then derives name from bin. This caused two related inconsistencies:

• file-based linting could never trigger missing-name, while stdin linting could because it has no filename
• include also called parse_file(), so an empty included fragment acquired its own filename as metadata and overwrote the parent spec, producing a spurious missing-cmd-help

The fallback now applies only to the top-level file. Explicit metadata in included specs still merges normally.

Closes #784.
Closes #785.

Validation

• cargo fmt --all -- --check
• cargo test --all --all-features
• cargo clippy --all --all-features -- -D warnings
• reproduced both reported cases with metadata-free file/stdin input and an empty included override

AI-assisted — Tool: Codex; model: openai/gpt-5; version: unavailable.

Summary by CodeRabbit

• Bug Fixes
  • Removed an unnecessary lint warning for specifications that omit both a name and a binary.
  • Such specifications are now accepted without lint issues.
  • Prevented included specification files from incorrectly inheriting their filenames as names or binary identifiers.
  • Preserved metadata inferred from the primary specification file while ignoring metadata from included files.

[coderabbitai]

📝 Walkthrough

Walkthrough

Filename metadata inference now applies to root specs but not included specs. The unreachable missing-name lint warning was removed. Regression tests cover both parsing behavior and argument-only specifications.

Changes

Spec metadata and lint behavior

Layer / File(s)	Summary
Control filename metadata inference lib/src/spec/mod.rs	Root parsing retains filename-based name and bin inference. Included specs disable this inference. A regression test verifies the root and included metadata behavior.
Remove unreachable lint warning cli/src/cli/lint.rs	The missing-name warning is removed. A test confirms that an argument-only specification is lint-clean.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: gaojunran

Poem

A rabbit parses files with care,
Root names stay, includes stay bare.
The lint trail has no warning sign,
Tests hop through each changed line.
Clean specs greet the morning air.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR resolves issue #785 by removing the unreachable warning and testing specs without explicit name or bin.
Out of Scope Changes check	✅ Passed	The parser adjustment and regression tests support consistent metadata and lint behavior described in the PR objectives.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main parser change that prevents metadata inference for included specs.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR removes the missing-name lint and prevents included files from contributing filename-inferred metadata to their parent spec.

• Accepts metadata-free specs consistently for file and stdin linting.
• Parses included specs without inferring their names or binaries from included filenames.
• Adds regression coverage for both behaviors.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
cli/src/cli/lint.rs	Removes the metadata warning and adds coverage showing metadata-free specs are accepted.
lib/src/spec/mod.rs	Separates file parsing from filename metadata inference so included files cannot overwrite root metadata with their filenames.

_{Reviews (2): Last reviewed commit: "fix(spec): avoid inferred metadata from ..." | Re-trigger Greptile}

[greptile-apps]

Overbroad regression assertion

Requiring the entire issue list to be empty couples this regression test to every independent lint rule, so legitimate new diagnostics will break the test even when metadata-free specs remain accepted. Check specifically that missing-name is absent instead.

Suggested change

	assert!(issues.is_empty());
	assert!(!issues.iter().any(|i| i.code == "missing-name"));

Knowledge Base Used: CLI Command Dispatch (usage binary)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
markdown	▂▂▁▂▆▆▆▇▆▆█▇▇▇▇	110,538,839 → 110,531,340	-0.01%	11.10 → 15.98ms	+43.93%
startup	▁▂▃▂▂▂▂▃▃▂▄▅██▅	1,204,352 → 1,200,480	-0.32%	0.95 → 1.08ms	+13.89%

No instruction-count regression above 1%.

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{23cb52a06f8d vs 996949938884 · measured on the runner, not pushed to the history.}