docs(spec): document when a root mount runs, and overrides_default - #812
Conversation
|
Warning Review limit reached
Next review available in: 1 minute You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryUpdates the command specification reference to accurately document root mount resolution and the
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "docs(spec): document when a root mount r..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
The mount page describes only the behavior of the first commit in #806 and never picked up what the later ones changed: it still claims flags never trigger discovery, which is untrue of completions and help, and `overrides_default` shipped with no documentation at all. My fault, and worth writing down how: the edits were made by string replacement against text prettier had already rewrapped and turned `*own*` into `_own_`, so both replacements silently matched nothing. I said in the pull request that the page had been corrected, and it had not. Diff verified this time. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Cleaning up after myself. The mount documentation on
maindescribes only the first commit of #806 and missed everything the later ones changed:overrides_defaultis undocumented entirely, despite shipping.How it happened, since it is worth knowing
Both docs edits in that PR were string replacements against text prettier had already reformatted — rewrapped lines, and
*own*turned into_own_. The replacements matched nothing and silently did nothing, and I asserted in a PR comment that the page had been corrected. It had not.The lesson is mechanical: a
.replace()that no-ops leaves no trace, so an edit made that way needs its diff checked rather than its exit code. This one is verified —git diff --statshows 25 insertions, and the rendered diff is in the commit.What the page says now
A table for when the root's mount runs, since "lazily" was never the whole truth:
Plus
overrides_default, and why it governs completions too: a completion offering a command that running would hand to the default subcommand instead is worse than not offering it.AI-assisted — Tool: Claude Code; model: anthropic/claude-fable-5; version: unavailable.
Note
Low Risk
Documentation-only change to the mount reference; no runtime or security-sensitive code is modified.
Overview
Corrects the root
mountdocs that previously claimed discovery never runs for flags and omitted later behavior.Adds a table for when a root mount runs: up front for completions/help, lazily for unmatched parse words, and never for flags during parse. Also documents
overrides_default, including thatdefault_subcommandoutranks discovery for both parses and completions unless a mount opts in.Reviewed by Cursor Bugbot for commit f942f04. Bugbot is set up for automated code reviews on this repo. Configure here.