[12.x] Fix TypeError in userFromRecaller() when the recaller matches no user - #61397
Merged
Merged
Conversation
lazerg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61386 added a password hash check to
userFromRecaller(), butretrieveByToken()still returns null whenever the remember token has been rotated or the user no longer exists. On that path$userPasswordis null, sohash_equals()gets a null argument and throws instead of the request falling through as a guest.Returning as soon as the provider gives back no user restores the 12.68 behavior.
Fixes #61396