Skip to content

Implemented SkipMultiCursorBack as a counterpart to SkipMultiCursor - #3404

Merged
dmaluka merged 1 commit into
micro-editor:masterfrom
masmu:feature/skip-multi-cursor-back
Sep 16, 2024
Merged

Implemented SkipMultiCursorBack as a counterpart to SkipMultiCursor#3404
dmaluka merged 1 commit into
micro-editor:masterfrom
masmu:feature/skip-multi-cursor-back

Conversation

@masmu

@masmu masmu commented Jul 28, 2024

Copy link
Copy Markdown
Contributor

This PR adds SkipMultiCursorBack as a counterpart to SkipMultiCursor.

Since Undo does not reverse selections, you are somehow stuck if you have used SkipMultiCursor incorrectly one too many times.

The name for this new action is up for debate. Since I didn't want to change the name of SkipMultiCursor I could not think of something better than SkipMultiCursorBack.

In case changing the name of SkipMultiCursor is an option i would throw the following candidates into the ring:

  • SkipNextMultiCursor and SkipPreviousMultiCursor
  • SkipMultiCursorForward and SkipMultiCursorBackward

Comment thread internal/action/actions.go
@dmaluka

dmaluka commented Sep 15, 2024

Copy link
Copy Markdown
Collaborator

The name for this new action is up for debate. Since I didn't want to change the name of SkipMultiCursor I could not think of something better than SkipMultiCursorBack.

In case changing the name of SkipMultiCursor is an option i would throw the following candidates into the ring:

  • SkipNextMultiCursor and SkipPreviousMultiCursor
  • SkipMultiCursorForward and SkipMultiCursorBackward

To me SkipMultiCursorBack doesn't seem a very bad name. After all, what these 2 actions do is skip the current multicursor, not the next or previous one. (But I'd also welcome any better name suggestions.)

Comment thread internal/action/actions.go Outdated
@masmu
masmu force-pushed the feature/skip-multi-cursor-back branch from b25eb52 to 2983f84 Compare September 15, 2024 13:42
Comment thread internal/action/actions.go Outdated
@masmu
masmu force-pushed the feature/skip-multi-cursor-back branch from 2983f84 to ae26a01 Compare September 15, 2024 14:11
Comment thread internal/action/actions.go Outdated
@masmu
masmu force-pushed the feature/skip-multi-cursor-back branch from ae26a01 to 12d8a4d Compare September 15, 2024 14:40
@dmaluka
dmaluka requested a review from JoeKar September 15, 2024 14:45

@JoeKar JoeKar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me too 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants