Replaced wmic call with windows-process-tree - #123895
Merged
Andre Weinand (weinand) merged 2 commits intoMay 18, 2021
Merged
Conversation
Daniel Imms (Tyriar)
approved these changes
May 14, 2021
Daniel Imms (Tyriar)
left a comment
Daniel Imms (Tyriar)
left a comment
Contributor
There was a problem hiding this comment.
I believe the usage looks fine, will leave this for Andre Weinand (@weinand) for final review
Andre Weinand (weinand)
approved these changes
May 18, 2021
Andre Weinand (weinand)
added
the
debug
Contributor
|
Daniel Gary (@danielgary) thanks for the PR! |
Contributor
Author
|
Thanks for the approval! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #123296
According to https://github.com/microsoft/vscode-windows-process-tree, this has performance benefits as well as not being dependent on WMIC.