Skip to content

Update tab hover styles and add test for tab action fading - #331476

Merged
Lee Murray (mrleemurray) merged 1 commit into
mainfrom
mrleemurray/determined-moccasin-mongoose
Aug 18, 2026
Merged

Update tab hover styles and add test for tab action fading#331476
Lee Murray (mrleemurray) merged 1 commit into
mainfrom
mrleemurray/determined-moccasin-mongoose

Conversation

@mrleemurray

Copy link
Copy Markdown
Contributor

Enhance tab hover styles for better visual feedback and introduce a test to verify the fading behavior of tab actions when they overlay clean tabs. This ensures a more consistent user experience in the Modern UI.

Resolves #330998

Resolves #330993

Copilot AI balanced review requested due to automatic review settings August 18, 2026 14:26
@mrleemurray
Lee Murray (mrleemurray) enabled auto-merge (squash) August 18, 2026 14:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Modern UI tab hover backgrounds and limits action fading to overlaid clean tabs.

Changes:

  • Clears inactive tab hover backgrounds in all editor groups.
  • Restricts action gradients and adds browser coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modernUI.contribution.test.ts Tests action fading conditions.
tabs.css Corrects hover and action-gradient selectors.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 2c314930 Current: e7561374

Changed (8)

editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/TabStates/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/TabStates/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveAction/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveAction/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveHover/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/ActiveHover/Light
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/SelectedAction/Dark
Before After
before after
editor/editorTabBar/editorTabBar/ModernUIOn/ThemeColors/SelectedAction/Light
Before After
before after

@mrleemurray
Lee Murray (mrleemurray) merged commit 001bbef into main Aug 18, 2026
28 checks passed
@mrleemurray
Lee Murray (mrleemurray) deleted the mrleemurray/determined-moccasin-mongoose branch August 18, 2026 14:44
@vs-code-engineering vs-code-engineering Bot added this to the 1.135.0 milestone Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modern UI: Hovered inactive unfocused editor tabs have a strange background Modern UI: Tab action buttons have gradient effects even if not overlaid

3 participants