BlueScreen: add renderToFile - #130
Closed
Vrtak-CZ wants to merge 1 commit into
Closed
Conversation
Contributor
|
Nice 👍 |
Member
There was a problem hiding this comment.
IMHO this conditions should stay in Logger.
Contributor
Author
There was a problem hiding this comment.
Ok but if I move that to Logger I must pass resource to this method from Logger or we should have "copy&paste" code in Logger and in this method. But file as resource for this method doesn't looks good for me (it's just feeling).
Do you have better idea?
Member
There was a problem hiding this comment.
File should be opened twice, via @fopen($file, 'x') in logger and fopen($file, 'w') in Bluescreen.
dg
force-pushed
the
master
branch
4 times, most recently
from
April 21, 2016 12:19
5dd8d3e to
5ecd8e7
Compare
dg
pushed a commit
that referenced
this pull request
May 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using Tracy with Monolog and we only need "render" bluescreen to file. So I add renderToFile method to BlueScreen (code moved from Logger).
I'm not sure with method name. You maybe have better idea.