Websocket connections incorrectly timing out after 2 minutes in node 14.11? Possible regression

[liamuk]

Hi,

After upgrading to node 14.11, one of our services that is a websocket server using https://github.com/websockets/ws started mysteriously disconnecting clients every 2 minutes.

Downgrading to node 14.9 seems to fix the issue.

This line on commit 753f3b247a, combined with the fact that the documentation says the default value for this is 0, and it is 0 in lib/_http_server.js, makes me suspicious. Especially given that clients are getting disconnected precisely every 2 minutes.

cc @ronag

[ronag]

Do you have a minimal example for repro?

[liamuk]

I'll see if I can put one together today.

Is this line in lib/https.js supposed to be 120 * 1000, and not 0?

[ronag]

You can work around it by setting it to 0 yourself in your code until we have a fix.