Skip to content

test_runner: always use paths to identify files #51610

Description

@mcollina

Currently the file property emitted by different events in the test runner can be file URLs or paths.

{"type":"test:enqueue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js","line":1,"column":1,"file":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:dequeue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js","line":1,"column":1,"file":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:enqueue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js","line":1,"column":1,"file":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}
{"type":"test:enqueue","data":{"nesting":0,"name":"add2","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:dequeue","data":{"nesting":0,"name":"add2","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:start","data":{"nesting":0,"name":"add2","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:pass","data":{"name":"add2","nesting":0,"testNumber":1,"details":{"duration_ms":0.477958},"line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add2.test.js"}}
{"type":"test:dequeue","data":{"nesting":0,"name":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js","line":1,"column":1,"file":"/Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}
{"type":"test:enqueue","data":{"nesting":0,"name":"add","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}
{"type":"test:dequeue","data":{"nesting":0,"name":"add","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}
{"type":"test:start","data":{"nesting":0,"name":"add","line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}
{"type":"test:pass","data":{"name":"add","nesting":0,"testNumber":2,"details":{"duration_ms":0.424333},"line":4,"column":1,"file":"file:///Users/matteo/Repositories/borp/fixtures/ts-esm/dist/test/add.test.js"}}

My take on those is that they should be paths and not file URLs, or in any case they should be consistent.


On a side note, the file URLs generated by this are unparsable on windows, because there is an additional /, e.g. file:///C:\\.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.test_runnerIssues and PRs related to the test runner subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions