Skip to content

GitHub Actions Windows Coverage build on is broken #59369

Description

@richardlau

The Coverage Windows workflow on GitHub Actions is failing on main.

e.g. for 4f5d11e:
https://github.com/nodejs/node/actions/runs/16752649115/job/47426712106#step:6:6232

  In file included from src\quic\data.cc:4:
src\quic\data.h(159,5): error : expected identifier [D:\a\node\node\libnode.vcxproj]
src\quic\data.h(111,5): message : expanded from macro 'QUIC_TRANSPORT_ERRORS' [D:\a\node\node\libnode.vcxproj]
C:\Program Files (x86)\Windows Kits\10\Include\10.0.26100.0\shared\winerror.h(232,18): message : expanded from macro 'NO_ERROR' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(152,46): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(156,50): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(160,51): error : invalid use of non-static data member 'base' [D:\a\node\node\libnode.vcxproj]
src\quic\data.cc(386,1): error : expected unqualified-id [D:\a\node\node\libnode.vcxproj]
src\quic\data.h(111,5): message : expanded from macro 'QUIC_TRANSPORT_ERRORS' [D:\a\node\node\libnode.vcxproj]

AFAIK the Jenkins CI on Windows is passing, so I assume this is compiler level related?
cc @jasnell @nodejs/platform-windows

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    quicIssues and PRs related to the QUIC transport implementation.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions