doc: clarify ERR_AMBIGUOUS_ARGUMENT - #22542
Closed
Trott wants to merge 2 commits into
Closed
Conversation
nodejs-github-bot
added
doc
BridgeAR
approved these changes
Aug 27, 2018
| An function argument is being used in a way that suggests that the function | ||
| signature may be misunderstood. This is thrown by the `assert` module when the | ||
| `message` parameter in `assert.throws(block, message)` matches the error message | ||
| thrown by `block` because that usage suggests that the user believes `message` |
Member
There was a problem hiding this comment.
We should consider renaming block to fn or function.
Member
Author
There was a problem hiding this comment.
Agreed, and I think it should be fn to avoid the problem of function being a keyword in JavaScript.
Trott
added
the
author ready
Member
Author
vsemozhetbyt
approved these changes
Aug 27, 2018
Contributor
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
lpinca
approved these changes
Aug 27, 2018
Trott
added
the
fast-track
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Aug 27, 2018
PR-URL: nodejs#22542 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
Author
|
Landed in d8855e4 |
addaleax
pushed a commit
that referenced
this pull request
Aug 27, 2018
PR-URL: #22542 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
PR-URL: #22542 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
PR-URL: #22542 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes