Skip to content

async_hook: Add the hasHooks function - #32656

Closed
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:refactor-has-hooks
Closed

async_hook: Add the hasHooks function#32656
rickyes wants to merge 1 commit into
nodejs:masterfrom
rickyes:refactor-has-hooks

Conversation

@rickyes

@rickyes rickyes commented Apr 4, 2020

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the async_hooks Issues and PRs related to the async hooks subsystem. label Apr 4, 2020
Comment thread lib/internal/async_hooks.js
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30532/ (:heavy_check_mark:)

@addaleax addaleax added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 7, 2020
addaleax pushed a commit that referenced this pull request Apr 7, 2020
PR-URL: #32656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

addaleax commented Apr 7, 2020

Copy link
Copy Markdown
Member

Landed in 1c816f0 🎉

@addaleax addaleax closed this Apr 7, 2020
targos pushed a commit that referenced this pull request Apr 12, 2020
PR-URL: #32656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
PR-URL: #32656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes
rickyes deleted the refactor-has-hooks branch April 19, 2020 06:32
targos pushed a commit that referenced this pull request Apr 22, 2020
PR-URL: #32656
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs with CI started, the required approvals, and no outstanding review comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants