timers: correct explanation in comment - #35437
Closed
wjabbour wants to merge 1 commit into
Closed
Conversation
wjabbour
commented
Oct 1, 2020
wjabbour
commented
Contributor
- documentation is changed or added
- commit message follows [commit guidelines]
nodejs-github-bot
added
the
timers
Member
|
@nodejs/timers |
apapirovski
approved these changes
Oct 3, 2020
Contributor
|
While this is accurate, I also don't think the current is inaccurate. Both descriptions are strictly speaking, incomplete. It's also kind of arguable whether the comment really says anything that the code doesn't already express... |
Contributor
Author
|
Yeah I thought about removing the comment entirely |
Trott
approved these changes
Oct 5, 2020
github-actions
Bot
removed
the
request-ci
Collaborator
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 25, 2020
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
landed in 20a6ddc |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #35437 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
