Skip to content

tools: only use 2 cores for macos action - #36169

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:two-cpus-actions-mac
Closed

tools: only use 2 cores for macos action#36169
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:two-cpus-actions-mac

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 18, 2020
Comment thread .github/workflows/test-macos.yml
@MylesBorins MylesBorins added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Nov 19, 2020
@MylesBorins

Copy link
Copy Markdown
Contributor Author

Can we fast track?

@MylesBorins

Copy link
Copy Markdown
Contributor Author

Landed in efbec85

MylesBorins added a commit that referenced this pull request Nov 20, 2020
There are only 2 cores available so we shouldn't be using -j8

Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources

PR-URL: #36169
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
codebytere pushed a commit that referenced this pull request Nov 22, 2020
There are only 2 cores available so we shouldn't be using -j8

Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources

PR-URL: #36169
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@codebytere codebytere mentioned this pull request Nov 22, 2020
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
There are only 2 cores available so we shouldn't be using -j8

Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources

PR-URL: #36169
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
BethGriggs pushed a commit that referenced this pull request Dec 10, 2020
There are only 2 cores available so we shouldn't be using -j8

Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources

PR-URL: #36169
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
@BethGriggs BethGriggs mentioned this pull request Dec 10, 2020
BethGriggs pushed a commit that referenced this pull request Dec 15, 2020
There are only 2 cores available so we shouldn't be using -j8

Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources

PR-URL: #36169
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants