Skip to content

test: account for OOM risks in heapsnapshot-near-heap-limit tests - #37761

Merged
Trott merged 1 commit into
nodejs:masterfrom
joyeecheung:snapshot-limit
Mar 20, 2021
Merged

test: account for OOM risks in heapsnapshot-near-heap-limit tests#37761
Trott merged 1 commit into
nodejs:masterfrom
joyeecheung:snapshot-limit

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Mar 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #36961

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Mar 15, 2021
@joyeecheung

joyeecheung commented Mar 15, 2021

Copy link
Copy Markdown
Member Author

stress test: https://ci.nodejs.org/job/node-stress-single-test/225/

@joyeecheung

joyeecheung commented Mar 16, 2021

Copy link
Copy Markdown
Member Author

stress test for the worker one: https://ci.nodejs.org/job/node-stress-single-test/226/

@nodejs-github-bot

nodejs-github-bot commented Mar 16, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36733/

@RaisinTen

RaisinTen commented Mar 16, 2021

Copy link
Copy Markdown
Member

Nit: Should we use this in the commit message so that the related issue gets closed when this lands?

Fixes: https://github.com/nodejs/node/issues/36961

@nodejs-github-bot

nodejs-github-bot commented Mar 18, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36776/

@joyeecheung @Trott
test: account for OOM risks in heapsnapshot-near-heap-limit tests
a41c3e1 
PR-URL: nodejs#37761
Fixes: nodejs#36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Trott merged commit a41c3e1 into nodejs:master Mar 20, 2021
@Trott

Trott commented Mar 20, 2021

Copy link
Copy Markdown
Member

Landed in a41c3e1

ruyadorno pushed a commit that referenced this pull request Mar 24, 2021
@joyeecheung @ruyadorno
test: account for OOM risks in heapsnapshot-near-heap-limit tests
9f61cbd 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit that referenced this pull request Aug 8, 2021
@joyeecheung @targos
test: account for OOM risks in heapsnapshot-near-heap-limit tests
53b225a 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Aug 12, 2021
@joyeecheung @BethGriggs
test: account for OOM risks in heapsnapshot-near-heap-limit tests
abf1410 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 31, 2021
@joyeecheung @MylesBorins
test: account for OOM risks in heapsnapshot-near-heap-limit tests
c6ab198 
PR-URL: #37761
Fixes: #36961
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@marsonya marsonya marsonya approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate flaky test/parallel/test-heapsnapshot-near-heap-limit.js

6 participants

@joyeecheung @nodejs-github-bot @RaisinTen @Trott @marsonya @targos