Skip to content

doc: use example.com for examples - #41827

Merged
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
atesgoral:example-com-for-examples
Feb 3, 2022
Merged

doc: use example.com for examples#41827
nodejs-github-bot merged 1 commit into
nodejs:masterfrom
atesgoral:example-com-for-examples

Conversation

@atesgoral

Copy link
Copy Markdown
Contributor

As per RFC6761, use example.com for example/dummy domains. mysite.com that's currently used in http docs is an actual business.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. http Issues and PRs related to the http subsystem. labels Feb 2, 2022
@Trott Trott added author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Feb 3, 2022
@github-actions

github-actions Bot commented Feb 3, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Mesteery Mesteery added the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 3, 2022
@nodejs-github-bot
nodejs-github-bot merged commit f94f113 into nodejs:master Feb 3, 2022
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f94f113

@atesgoral
atesgoral deleted the example-com-for-examples branch February 3, 2022 14:07
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41827
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41827
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41827
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41827
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. http Issues and PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants