Skip to content

stream: WPT fixes for Compression Streams - #50712

Closed
panva wants to merge 3 commits into
nodejs:mainfrom
panva:wpt-compression-fixes
Closed

stream: WPT fixes for Compression Streams#50712
panva wants to merge 3 commits into
nodejs:mainfrom
panva:wpt-compression-fixes

Conversation

@panva

@panva panva commented Nov 13, 2023

Copy link
Copy Markdown
Member

Followup to #50631

  • adds the expected Symbol.toStringTag to CompressionStream and DecompressionStream
  • yields the expected error (TypeError) on corrupt inputs
  • updates the idlharness test files and expectations overall

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Nov 13, 2023
@panva

panva commented Nov 13, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/streams

@panva panva added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Nov 13, 2023
@panva
panva force-pushed the wpt-compression-fixes branch from eaf6907 to 00a38f5 Compare November 13, 2023 14:23
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2023
@nodejs-github-bot

This comment was marked as outdated.

Comment thread lib/internal/webstreams/adapters.js Outdated
Comment thread lib/internal/webstreams/adapters.js Outdated
Comment thread lib/internal/webstreams/adapters.js Outdated
Comment thread lib/internal/webstreams/adapters.js Outdated
@panva
panva force-pushed the wpt-compression-fixes branch from 100f25c to 74d8ee5 Compare November 14, 2023 08:50
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 18, 2023

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 19, 2023
nodejs-github-bot pushed a commit that referenced this pull request Nov 19, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva
panva deleted the wpt-compression-fixes branch November 19, 2023 07:37
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 23, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 27, 2023
PR-URL: nodejs#50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 29, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
UlisesGascon pushed a commit that referenced this pull request Dec 12, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@panva

panva commented Dec 15, 2023

Copy link
Copy Markdown
Member Author

Backport blocked until #50097 is also backported.

UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Jan 9, 2024
PR-URL: #50712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants