Skip to content

test: remove duplicate skip AIX - #54917

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
iwuliz:remove-unnecessary-skip-aix
Sep 15, 2024
Merged

test: remove duplicate skip AIX#54917
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
iwuliz:remove-unnecessary-skip-aix

Conversation

@iwuliz

@iwuliz iwuliz commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Skip AIX is already defined on the top, so the { skip: common.isAIX } is duplicated.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 13, 2024
@codecov

codecov Bot commented Sep 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.05%. Comparing base (e21984b) to head (9d1a59d).
Report is 134 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54917   +/-   ##
=======================================
  Coverage   88.04%   88.05%           
=======================================
  Files         651      651           
  Lines      183409   183409           
  Branches    35828    35823    -5     
=======================================
+ Hits       161487   161500   +13     
+ Misses      15174    15163   -11     
+ Partials     6748     6746    -2     

see 25 files with indirect coverage changes

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 13, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@lpinca lpinca added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 15, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 6db320a into nodejs:main Sep 15, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 6db320a

@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@iwuliz
iwuliz deleted the remove-unnecessary-skip-aix branch September 17, 2024 00:13
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants