Skip to content

Fix config.sample and preview provider - #38807

Merged
phil-davis merged 2 commits into
masterfrom
update_preview_providers
Jun 4, 2021
Merged

Fix config.sample and preview provider#38807
phil-davis merged 2 commits into
masterfrom
update_preview_providers

Conversation

@mmattel

@mmattel mmattel commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Description

When writing docs for owncloud/docs#2735 (Document the support for SGI Images) I ran into the issue that:

  • Update in config.sample.php to reflect the necessary changes
    (which will then be transported via a config-to-docs run
  • The PreviewManager did not had all necessary comments respectively had outdated information (there is no more an install possible on windows)

No code changes, text only!

Related Issue

Motivation and Context

Fix missing and wrong information

How Has This Been Tested?

With my own productive instance

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Comment thread config/config.sample.php Outdated
@owncloud owncloud deleted a comment from update-docs Bot Jun 4, 2021
@sonarqubecloud

sonarqubecloud Bot commented Jun 4, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
phil-davis merged commit 044cb11 into master Jun 4, 2021
@delete-merged-branch
delete-merged-branch Bot deleted the update_preview_providers branch June 4, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the support for SGI Images

2 participants