fix: federation token exchange - #41434
Merged
Merged
Conversation
DeepDiver1975
force-pushed
the
fix/federation-token-exchange
branch
2 times, most recently
from
January 14, 2026 10:48
cb622f1 to
2a0a32b
Compare
jvillafanez
approved these changes
Jan 14, 2026
| } | ||
|
|
||
| protected function isValidToken($url, $token) { | ||
| public function isValidToken($url, $token): bool { |
Member
There was a problem hiding this comment.
I'd keep it protected if possible. If it needs to be public due to the unit test, I'd write a comment to say that it's public due to the test and the public usage is discouraged.
DeepDiver1975
force-pushed
the
fix/federation-token-exchange
branch
from
January 14, 2026 11:58
2a0a32b to
02581ad
Compare
DeepDiver1975
changed the title
phil-davis
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: Disallow empty tokens when pairing trusted servers
An empty token could be used to pair trusted servers, which is not secure.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: