Fix error reporting on Windows when an error is raised in the pager - #3764
Merged
Conversation
This was
linked to
issues
Aug 13, 2026
kdeldycke
added
windows
kdeldycke
force-pushed
the
fix-pager-temp-file-unlink
branch
from
August 13, 2026 09:45
77cb0b0 to
cc0c676
Compare
kdeldycke
force-pushed
the
fix-pager-temp-file-unlink
branch
2 times, most recently
from
August 15, 2026 06:42
1c6c0a9 to
576a79d
Compare
kdeldycke
force-pushed
the
fix-pager-temp-file-unlink
branch
from
August 15, 2026 19:24
576a79d to
1f9cd54
Compare
Rowlando13
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #3739, which fix an issue on Windows where an exception gets replaced by a
PermissionError: [WinError 32]error instead of being raised within a pager.Also of note, this restore a fix that was pushed in 8.0.2 by #1905 / #1956 / #2036 which was not reintegrated by the #1572 new feature for 8.4.0.