Use Argument Clinic in sqlite3

[erlend-aasland]

BPO	40956
Nosy	@vstinner, @berkerpeksag, @serhiy-storchaka, @corona10, @pablogsal, @erlend-aasland
PRs	bpo-40956: Use Argument Clinic in sqlite3 module #20826 bpo-40956: Convert _sqlite3 module level functions to Argument Clinic #22484 bpo-41861: Convert _sqlite3 CursorType and ConnectionType to heap types #22478 bpo-40956: Convert _sqlite3.Connection to Argument Clinic #23057 bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341 bpo-40956: Fix sqlite3 AC code #23837 bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 #23838 bpo-40956: Convert _sqlite3.Row to Argument Clinic #23964 bpo-40956: Convert _sqlite3.Cursor to Argument Clinic #24007 bpo-40956: Convert _sqlite3.Cache to Argument Clinic #24135 bpo-40956: fix sqlite3.Cursor.fetchmany() default value #24214 bpo-40956: Convert sqlite3.connect and sqlite3.Connection.__init__ to AC #24421 bpo-40956: [regression] first argument in sqlite3.Connection.backup is mandatory #24503

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-06-20.20:29:03.608>
created_at = <Date 2020-06-12.10:05:35.702>
labels = ['type-feature', 'library', '3.10']
title = 'Use Argument Clinic in sqlite3'
updated_at = <Date 2021-06-20.20:29:03.605>
user = 'https://github.com/erlend-aasland'

bugs.python.org fields:

activity = <Date 2021-06-20.20:29:03.605>
actor = 'erlendaasland'
assignee = 'none'
closed = True
closed_date = <Date 2021-06-20.20:29:03.608>
closer = 'erlendaasland'
components = ['Library (Lib)']
creation = <Date 2020-06-12.10:05:35.702>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 40956
keywords = ['patch']
message_count = 24.0
messages = ['371347', '378558', '378560', '378561', '378562', '378571', '380042', '380043', '380047', '383301', '383303', '383841', '384000', '384444', '385012', '385015', '385019', '385036', '385053', '385058', '386814', '396188', '396191', '396197']
nosy_count = 6.0
nosy_names = ['vstinner', 'berker.peksag', 'serhiy.storchaka', 'corona10', 'pablogsal', 'erlendaasland']
pr_nums = ['20826', '22484', '22478', '23057', '23341', '23837', '23838', '23964', '24007', '24135', '24214', '24421', '24503']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40956'
versions = ['Python 3.10']

[erlend-aasland]

Use Argument Clinic in sqlite3.

[corona10]

What's the purpose of using AC, did the change improve performance?
It can make hard to track the code history.

[erlend-aasland]

The primary reason is that it will be provide easy access to module state.

The first step in making sqlite3 support multiphase init was to create heap types. The second step is argument clinic. The third will be to use AC for module state. The last step will then be final multiphase support.

Also, IMHO, AC greatly improves the body of methods (readability => maintainability, hardened parsing of arguments)

[erlend-aasland]

Also, see the comment from Victor here: #22478 (comment)

[corona10]

Also, see the comment from Victor here: #22478 (comment)

Okay got it

[erlend-aasland]

By the way, what's the preferred way to benchmark performance?

[corona10]

New changeset 7d21027 by Erlend Egeberg Aasland in branch 'master':
bpo-40956: Convert _sqlite3 module level functions to Argument Clinic (GH-22484)
7d21027

[corona10]

@erlendaasland

Thank you erlendaasland for working on #66674.
This time was a good time to review my AC knowledge ;)

[erlend-aasland]

Thank you erlendaasland for working on #66674.

… and thank you for taking the time to review this!

[corona10]

New changeset 1ba82bb by Erlend Egeberg Aasland in branch 'master':
bpo-40956: Convert _sqlite3.Connection to Argument Clinic (GH-23341)
1ba82bb

[corona10]

New changeset 2179349 by Dong-hee Na in branch 'master':
bpo-40956: Fix sqlite3 AC code (GH-23837)
2179349

[corona10]

New changeset 3ccef1c by Erlend Egeberg Aasland in branch 'master':
bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 2 (GH-23838)
3ccef1c