Directory.Build.props/targets leaks from folders above the repo

[dfederm]

BPO	45931
Nosy	@pfmoore, @tjguk, @zware, @zooba, @miss-islington, @dfederm
PRs	bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo #29854 [3.10] bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) #29855 [3.9] bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854) #29856

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-11-29.23:06:25.506>
created_at = <Date 2021-11-29.19:43:33.801>
labels = ['3.10', 'build', '3.9', 'OS-windows', '3.11']
title = 'Directory.Build.props/targets leaks from folders above the repo'
updated_at = <Date 2021-11-29.23:08:57.143>
user = 'https://github.com/dfederm'

bugs.python.org fields:

activity = <Date 2021-11-29.23:08:57.143>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2021-11-29.23:06:25.506>
closer = 'steve.dower'
components = ['Build', 'Windows']
creation = <Date 2021-11-29.19:43:33.801>
creator = 'dfederm'
dependencies = []
files = []
hgrepos = []
issue_num = 45931
keywords = ['patch']
message_count = 6.0
messages = ['407320', '407325', '407331', '407332', '407333', '407334']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'miss-islington', 'dfederm']
pr_nums = ['29854', '29855', '29856']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue45931'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[dfederm]

When building with Visual Studio 2017+, any Directory.Build.props/targets above the repo in the file structure (eg. in the parent repo when the python repo is a submodule) will be imported automatically.

[zooba]

Nice catch, thanks!

Did you start the CLA process already? (I personally would exempt this PR from it as "not sufficiently creative", but I'm not sure I'm allowed to do that anymore...)

[zooba]

New changeset 734ed35 by David Federman in branch 'main':
bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (GH-29854)
734ed35

[zooba]

Looks like it's gone through. Thanks!