Crash: Must not defer during final iteration

[cbornet]

Crash Report

Mypy crashed when changing the import path of the parent class.

./langchain_core/language_models/base.py:116: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.19.1

Traceback

Traceback (most recent call last):
  File "mypy/semanal.py", line 7568, in accept
  File "mypy/nodes.py", line 995, in accept
  File "mypy/semanal.py", line 978, in visit_func_def
  File "mypy/semanal.py", line 1023, in analyze_func_def
  File "mypy/semanal.py", line 7214, in defer
AssertionError: Must not defer during final iteration

The crash happens on checking

class BaseLanguageModel(
    RunnableSerializable[LanguageModelInput, LanguageModelOutputVar], ABC
)

when changing the RunnableSerializable import from

from langchain_core.runnables import Runnable, RunnableSerializable

to

from langchain_core.runnables.base import Runnable, RunnableSerializable

To Reproduce

See langchain-ai/langchain#34520

• clone the project

git clone https://github.com/cbornet/langchain.git

• checkout PR branch

git checkout fix-tc

• go to core sub-project

cd core

• run mypy (using uv)

uv run --all-groups mypy . --show-traceback

Your Environment

• Mypy version used: 1.18.2, 1.19.1
• Mypy command-line flags:
• Mypy configuration options from pyproject.toml:

plugins = ["pydantic.mypy"]
strict = true
enable_error_code = "deprecated"
disallow_any_generics = false

• Python version used: 3.10, 3.11, 3.12, 3.13, 3.14
• Operating system and version: macOS 15.1, Ubuntu 24.04

[bryevdv]

We seem to be running into this with the latest dev version of Bokeh 3.9.0.dev9 (which is pip-installable).
Given

# main.py

import bokeh.models.graphics

Then

❯ mypy --show-traceback main.py
/Users/bryan/work/bokeh/src/bokeh/models/misc/group_by.pyi:23: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.19.1
Traceback (most recent call last):
  File "mypy/semanal.py", line 7568, in accept
  File "mypy/nodes.py", line 995, in accept
  File "mypy/semanal.py", line 978, in visit_func_def
  File "mypy/semanal.py", line 1023, in analyze_func_def
  File "mypy/semanal.py", line 7214, in defer
AssertionError: Must not defer during final iteration
/Users/bryan/work/bokeh/src/bokeh/models/misc/group_by.pyi:23: : note: use --pdb to drop into pdb

ref: bokeh/bokeh#14817

We did just merge a new substantial change in how we handle our type stubs. Any guidance on how to structure this code differently as a workaround, or pointers to any usage error on our part if that is the case, would be appreciated.

Edit: I would note that this error persists with latest dev mypy-1.20.0+dev.60d136e8fccf9067c873b10f97ec5decec3b08e8

[ilevkivskyi]

@cbornet Could you please double-check if the original issue still persists with the current mypy master? I merged a PR few minutes ago that may fix your problem as well.

[cbornet]

@ilevkivskyi thanks for looking into these issues.

I still have the same error on latest master:

./langchain_core/language_models/base.py:116: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
Please report a bug at https://github.com/python/mypy/issues
version: 1.20.0+dev.7029712ac6e6ef3b0dc665976d36afd4f32d083d
Traceback (most recent call last):
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/bin/mypy", line 10, in <module>
    sys.exit(console_entry())
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/__main__.py", line 15, in console_entry
    main()
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/main.py", line 135, in main
    res, messages, blockers = run_build(sources, options, fscache, t0, stdout, stderr)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/main.py", line 219, in run_build
    res = build.build(sources, options, None, flush_errors, fscache, stdout, stderr)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 368, in build
    result = build_inner(
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 465, in build_inner
    graph = dispatch(sources, manager, stdout)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 3289, in dispatch
    process_graph(graph, manager)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 3702, in process_graph
    done, still_working, results = manager.wait_for_done(graph)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 1176, in wait_for_done
    process_stale_scc(graph, next_scc, self)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/build.py", line 3859, in process_stale_scc
    mypy.semanal_main.semantic_analysis_for_scc(graph, scc, manager.errors)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal_main.py", line 95, in semantic_analysis_for_scc
    process_functions(graph, scc, patches)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal_main.py", line 304, in process_functions
    process_top_level_function(
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal_main.py", line 343, in process_top_level_function
    deferred, incomplete, progress = semantic_analyze_target(
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal_main.py", line 409, in semantic_analyze_target
    analyzer.refresh_partial(
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal.py", line 703, in refresh_partial
    self.accept(node)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal.py", line 7616, in accept
    node.accept(self)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/nodes.py", line 1004, in accept
    return visitor.visit_func_def(self)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal.py", line 976, in visit_func_def
    self.analyze_func_def(defn)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal.py", line 1021, in analyze_func_def
    self.defer(defn)
  File "/Users/christophe.bornet/workspace/langchain/libs/core/.venv/lib/python3.10/site-packages/mypy/semanal.py", line 7262, in defer
    assert not self.final_iteration, "Must not defer during final iteration"
AssertionError: Must not defer during final iteration

[ilevkivskyi]

Hm, OK, I see you are using the pydantic plugin. May be a duplicate of other issue, can you reproduce the crash without the pydantic plugin?

[cbornet]

Indeed, if I remove the pydantic plugin, the crash doesn't occur anymore.