Support _value_ as a fallback for ellipsis Enum members - #19352
Merged
JukkaL merged 9 commits intoJul 9, 2025
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sterliakov
marked this pull request as ready for review
June 28, 2025 12:12
This comment has been minimized.
This comment has been minimized.
A5rocks
approved these changes
Jun 29, 2025
A5rocks
left a comment
A5rocks
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, a couple nitpicks.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…19334-respect-enum-sunder-value
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Jul 9, 2025
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good, except for a nit about cyclic import dependencies. This is good to merge as is, since the issue is pretty minor, but it would be nice you can fix it in a follow-up PR.
|
|
||
| import mypy.plugin # To avoid circular imports. | ||
| from mypy.nodes import TypeInfo | ||
| from mypy.checker import TypeChecker |
Collaborator
There was a problem hiding this comment.
It's a bit unfortunate that we have another circular import dependency. What about adding adding a helper method for checking whether we are type checking a stub file to the checker api? (It's okay to do this in a follow-up PR.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19334.
This does not affect enums with explicit values different from ellipsis and is limited to enums defined in stub files.