Docs for mock data generation give incorrect counts

[tomihawk]

The documentation at https://dev.twitch.tv/docs/cli/mock-api-command and https://github.com/twitchdev/twitch-cli/blob/main/docs/mock-api.md states that the twitch mock-api generate command will default to generate 10 users but it seems to default to 1. The first link also says that if you run twitch mock-api start without having generated any data it will generate the default 10, but it seems to generate 25 users.

The 25 users seems to come from

twitch-cli/internal/mock_api/mock_server/server.go

Line 41 in fca40a4

err := generate.Generate(25)

or

twitch-cli/internal/events/mock_wss_server/server.go

Line 352 in fca40a4

err := generate.Generate(25)

I'm guessing the 1 comes from the &count variable being referenced at

twitch-cli/cmd/api.go

Line 103 in fca40a4

generateCmd.Flags().IntVarP(&count, "count", "c", 10, "Defines the number of fake users to generate.")

is not defined anywhere. I'm not a Go programmer so I'm not sure why the compiler would let you reference the memory address of an undefined variable but specifying a number with -c works fine.

[Xemdo]

Docs will stay at 10, but if the server is new it will generate 25. The generate command is to generate more users, with 10 was the default.

For it generating 1 instead of 10, this is because the count variable is referenced twice. First is here:, as you mentioned

twitch-cli/cmd/api.go

Line 103 in fca40a4

generateCmd.Flags().IntVarP(&count, "count", "c", 10, "Defines the number of fake users to generate.")

And again at

twitch-cli/cmd/events.go

Line 114 in fca40a4

triggerCmd.Flags().IntVarP(&count, "count", "c", 1, "Count of events to events. This will simulate a sub gift, or large number of cheers.")

The one in events.go must be executed second, because it overrides. I'll split these variables up to avoid any issues.