Pretty Print disables when used

[erikreinert]

Expected Behavior

When using the --pretty-print argument - it should stay enabled and output something like this:

{
  "data": [
    {
      "broadcaster_type": "affiliate",
      "created_at": "2018-10-01T15:26:44.113951Z",
      "description": "The Alt-F4 Stream is an idea long time friends AT0TA and Blackglasses had of being able to game/stream together miles apart. We are real life friends that met long ago in a little town in Florida and kept our friendship over the years through video games. Find out more about us below!",
      "display_name": "TheAltF4Stream",
     ....
    }
  ]
}

Actual Behavior

It appears to be disabling the flag when used instead of keeping it enabled rendering non-pretty output:

{"data":[{"id":"264030156","login":"thealtf4stream","display_name":"TheAltF4Stream","type":"","broadcaster_type":"affiliate","description":"The Alt-F4 Stream is an idea long time friends AT0TA and Blackglasses had of being able to game/stream together miles apart. We are real life friends that met long ago in a little town in Florida and kept our friendship over the years through video games. Find out more about us below!","profile_image_url":"https://static-cdn.jtvnw.net/jtv_user_pictures/ffedad62-cc6e-497f-8eef-61e7fec4c9b4-profile_image-300x300.png","offline_image_url":"https://static-cdn.jtvnw.net/jtv_user_pictures/ce008d9e-a92f-4781-a2d0-4bba41061812-channel_offline_image-1920x1080.png","view_count":95898,"created_at":"2018-10-01T15:26:44.113951Z"}]}

Steps to Reproduce the Problem

1. Use the following command as an example and make sure --pretty-print is included.

twitch-cli api --pretty-print get users -q login=thealtf4stream

2. Should return a non-pretty output of your query.

Specifications

• Version: Beta Version 0.1.0
• Platform: Linux

[lleadbet]

Hi there!

You hit the nail on the head. It's a poorly named flag, so I may just need to rename it, but it's defaulted on and using it toggles it off.

I'll dig into this and see the better solve here.

[Soupertonic]

I don't seem to understand the issue in the code. The boolean is getting inverted and that is accompanied with this comment:
// default here is false to enable -p commands to toggle off without explicitly defining -p=false as -p false will not work. The below commands invert the bool to pass the true default.

I've been running some tests and everything seems to be working just fine without the invert. Let me show you. For debugging purposes the command now also outputs the pretty-print condition.

No pretty print (-p and --pretty-print absent)

Pretty print (-p specified, --pretty-print absent)

Pretty print (-p absent, --pretty-print specified)

Pretty print (-p and --pretty-print specified)

I'm missing some intel. Is pretty print supposed to be enabled by default and you have to explicitly specify a flag to disable pretty print?

EDIT

Is this the wanted behavior? You have to explicitly specify --unformatted, -u to disable pretty print. I think that's the desired solution because most people just wanna see the data. If they still wanna pipe the output they can use --unformatted.

[Soupertonic]

All it boils down to is to rename the pretty-print flag to unformatted. 😃

[lleadbet]

Followup, this has a fix merged but isn't in a release just yet. I'll make sure that I followup once we cut a release.