xbps-fetch: tilde character shouldn't be url-escaped

[gmbeard]

When using xbps-fetch, the tilde (~) character is being url encoded into %7e. This is causing at least one xbps srcpkg to fail when downloading its distfiles .

For example, the following fails to find the udptunnel distfile (note the tilde character in the path)...

$ xbps-fetch -v 'http://www.cs.columbia.edu/~lennox/udptunnel/udptunnel-1.1.tar.gz'

Examining the TTY output, I can see that the tilde is being url encoded...

requesting http://www.cs.columbia.edu/%7elennox/udptunnel/udptunnel-1.1.tar.gz

Using curl to download this file works fine.

[leahneukirchen]

Citing RFC 2396:

2.3 Unreserved Characters

   Data characters that are allowed in a URI but do not have a reserved
   purpose are called unreserved.  These include upper and lower case
   letters, decimal digits, and a limited set of punctuation marks and
   symbols.

      unreserved  = alphanum | mark

      mark        = "-" | "_" | "." | "!" | "~" | "*" | "'" | "(" | ")"

   Unreserved characters can be escaped without changing the semantics
   of the URI, but this should not be done unless the URI is being used
   in a context that does not allow the unescaped character to appear.

So I think the server is broken, but xbps probably still shouldn't encode the tilde.

[gmbeard]

@leahneukirchen Agreed. I've changed the issue title so as not to assign blame to xbps-fetch 🙂