Cherry-pick: Unblock ttl part drops for cold volumes - #1797
Merged
Merged
Conversation
…merges_in_cold_volumes Unblock ttl part drops for cold volumes
The 25.3 backport 8044e6a of upstream PR ClickHouse#94363 added test_size_limit_metric.py and filesystem_caches.xml but missed the filesystem_caches_path.xml config the test references, leaving the test broken with FileNotFoundError during cluster setup. Restore the file from upstream commit cc19d95 ("Fix test"). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
integration fails are pre-existing and need to be dealt with separately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from ClickHouse#90059.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Split part ranges by volume characteristics to enable TTL drop merges for cold volumes. After this patch, parts with a max TTL < now will be removed from cold storage. The algorithm will schedule only single part drops (ClickHouse#90059 by @Michicosun)
CI/CD Options
Exclude tests:
Regression jobs to run: