Repository navigation
Fix NodeHttpServer keep-alive requests during graceful shutdown - #8846
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ec25441 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep request and upgrade listeners attached while
preemptiveShutdownwaits for the HTTP server to drain, then remove them withEffect.ensuring. This lets requests on existing keep-alive connections receive a response instead of hanging after the listeners are detached.Restores the original minimal listener-cleanup fix and its single keep-alive shutdown regression. The patch changeset is unchanged. No new connection-close policy, forced-timeout behavior, or broader shutdown semantics are introduced.
Validation
nix develop -c pnpm test --run packages/platform/node/test/NodeHttpServer.test.ts: all 41 tests pass, including the restored regression.nix develop -c pnpm lint-fixnix develop -c pnpm checkgit diff --checkCloses EFF-1787
Closes #8728