Skip to content

chore: fix formatting lint error in SidebarFooterDefault - #41674

Merged
dionisio-bot[bot] merged 1 commit into
developfrom
refactor/min-lint-error
Aug 4, 2026
Merged

dionisio-bot[bot] merged 1 commit into
developfrom
refactor/min-lint-error

Conversation

@tassoevan

@tassoevan tassoevan commented Aug 4, 2026 •

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Formatting-only fix: the <Box> in SidebarFooterDefault was split across multiple lines and violated the Prettier printWidth config, failing lint. Collapsed it back to a single line. No behavior change.

Issue(s)

None.

Steps to test or reproduce

yarn lint passes on apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx.

Further comments

No changeset — this doesn't affect end users.

🤖 Generated with Claude Code

Task: ARCH-2326

Summary by CodeRabbit

  • Style
    • Reformatted the footer logo markup for improved code readability without changing its appearance or behavior.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@tassoevan
tassoevan requested a review from a team as a code owner August 4, 2026 01:41
@tassoevan tassoevan added this to the 8.8.0 milestone Aug 4, 2026
@dionisio-bot

dionisio-bot Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0441d4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan

Copy link
Copy Markdown
Member Author

/jira ARCH

@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c81f6880-17e1-452f-ab68-5e236aa19179

📥 Commits

Reviewing files that changed from the base of the PR and between dd60cf8 and 0441d4c.

📒 Files selected for processing (1)
  • apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx
📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: 📦 Build Packages
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check
  • GitHub Check: CodeQL-Build
  • GitHub Check: CodeQL-Build
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx
🧠 Learnings (2)
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

  • apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

  • apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx
🔇 Additional comments (1)
apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx (1)

30-30: LGTM!


Walkthrough

The footer logo Box JSX declaration was reformatted from multiple lines to one line. Its properties and behavior remain unchanged.

Changes

Footer formatting

Layer / File(s) Summary
Condense footer logo declaration
apps/meteor/client/sidebar/footer/SidebarFooterDefault.tsx
The footer logo Box declaration now uses one line. Padding, dimensions, styling, and sanitized HTML rendering remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: chore

Suggested reviewers: ricardogarim, yash-rajpal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the formatting lint fix in SidebarFooterDefault, which matches the pull request's main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@codecov

codecov Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.62%. Comparing base (dd60cf8) to head (0441d4c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41674      +/-   ##
===========================================
+ Coverage    68.47%   68.62%   +0.15%     
===========================================
  Files         4158     4162       +4     
  Lines       158225   158813     +588     
  Branches     27992    28183     +191     
===========================================
+ Hits        108345   108989     +644     
+ Misses       44707    44648      -59     
- Partials      5173     5176       +3     
Flag Coverage Δ
e2e 58.86% <ø> (-0.10%) ⬇️
e2e-api 45.70% <ø> (+<0.01%) ⬆️
unit 70.55% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 4, 2026
@dionisio-bot dionisio-bot Bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 4, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Aug 4, 2026
Merged via the queue into develop with commit e64e2bb Aug 4, 2026
56 checks passed
@dionisio-bot
dionisio-bot Bot deleted the refactor/min-lint-error branch August 4, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants