Skip to content

chore: deprecate checkFederationConfiguration meteor method - #41909

Merged
dionisio-bot[bot] merged 1 commit into
developfrom
chore/deprecate-check-federation-configuration
Aug 24, 2026
Merged

dionisio-bot[bot] merged 1 commit into
developfrom
chore/deprecate-check-federation-configuration

Conversation

@KevLehman

@KevLehman KevLehman commented Aug 24, 2026 •

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Adds a deprecation warning to the checkFederationConfiguration meteor method, following the standard methodDeprecationLogger.method pattern.

The method belongs to the old Matrix bridge federation stack and was only reachable through the hidden Federation_Matrix_check_configuration_button action setting, which is being removed in 9.0.0 (#41908). It has no other callers in the codebase and no replacement endpoint.

Issue(s)

Steps to test or reproduce

Call the checkFederationConfiguration meteor method — the server logs the deprecation warning and increments the deprecation metrics.

Further comments

Removal targeted at 9.0.0 alongside the Matrix bridge settings removal (#41908).

Review in cubic

Task: CORE-2623

Summary by CodeRabbit

  • Chores
    • Marked federation configuration checking as deprecated.
    • Existing validation and configuration checks remain unchanged.

@changeset-bot

changeset-bot Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a60fde5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f759bf3b-24a6-483c-a5fe-0f5407d71fc8

📥 Commits

Reviewing files that changed from the base of the PR and between 2a7de45 and 5869339.

📒 Files selected for processing (1)
  • apps/meteor/server/meteor-methods/platform/checkFederationConfiguration.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: Hacktron Security Check
  • GitHub Check: 🔨 Test Federation Matrix
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

  • apps/meteor/server/meteor-methods/platform/checkFederationConfiguration.ts
apps/meteor/**

📄 CodeRabbit inference engine (CLAUDE.md)

The main Rocket.Chat Meteor application resides in apps/meteor/; place its application code there rather than in other monorepo areas.

Files:

  • apps/meteor/server/meteor-methods/platform/checkFederationConfiguration.ts
🔇 Additional comments (1)
apps/meteor/server/meteor-methods/platform/checkFederationConfiguration.ts (1)

6-7: LGTM!

Also applies to: 17-18


Walkthrough

checkFederationConfiguration now logs deprecation version 9.0.0 before its existing authentication, authorization, and federation configuration checks.

Changes

Federation method deprecation

Layer / File(s) Summary
Add deprecation logging
apps/meteor/server/meteor-methods/platform/checkFederationConfiguration.ts
The method imports methodDeprecationLogger and records deprecation version 9.0.0. Existing checks remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 58693

This change only adds a deprecation warning and metric increment to the legacy federation-configuration method; no actionable merge-blocking risk remains after normal checks and review.

Suggested labels: type: chore

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: deprecating the checkFederationConfiguration Meteor method.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Warning

Errors were encountered while retrieving linked issues.

Errors (1)
  • CORE-2623: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dionisio-bot

dionisio-bot Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.32%. Comparing base (46f19eb) to head (a60fde5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #41909      +/-   ##
===========================================
- Coverage    69.33%   69.32%   -0.02%     
===========================================
  Files         4255     4255              
  Lines       168644   168645       +1     
  Branches     30023    30017       -6     
===========================================
- Hits        116929   116910      -19     
- Misses       46534    46554      +20     
  Partials      5181     5181              
Flag Coverage Δ
e2e 58.80% <ø> (-0.01%) ⬇️
e2e-api 45.86% <0.00%> (+<0.01%) ⬆️
unit 71.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KevLehman KevLehman added this to the 8.9.0 milestone Aug 24, 2026
@KevLehman

Copy link
Copy Markdown
Member Author

/jira CORE

@KevLehman
KevLehman marked this pull request as ready for review August 24, 2026 16:19
@KevLehman
KevLehman requested a review from a team as a code owner August 24, 2026 16:19
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Aug 24, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@rc-layne

rc-layne Bot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ Layne — scan incomplete

Layne could not analyze all changed content. Review the Check Run summary before merging.

@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Aug 24, 2026
@KevLehman
KevLehman force-pushed the chore/deprecate-check-federation-configuration branch from 5869339 to a60fde5 Compare August 24, 2026 17:08
@dionisio-bot dionisio-bot Bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 24, 2026
@dionisio-bot
dionisio-bot Bot added this pull request to the merge queue Aug 24, 2026
Merged via the queue into develop with commit 2162306 Aug 24, 2026
56 checks passed
@dionisio-bot
dionisio-bot Bot deleted the chore/deprecate-check-federation-configuration branch August 24, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider type: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants