chore: deprecate checkFederationConfiguration meteor method - #41909
Conversation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🧰 Additional context used📓 Path-based instructions (2)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
apps/meteor/**📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🔇 Additional comments (1)
Walkthrough
ChangesFederation method deprecation
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This change only adds a deprecation warning and metric increment to the legacy federation-configuration method; no actionable merge-blocking risk remains after normal checks and review. Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Looks like this PR is ready to merge! 🎉 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #41909 +/- ##
===========================================
- Coverage 69.33% 69.32% -0.02%
===========================================
Files 4255 4255
Lines 168644 168645 +1
Branches 30023 30017 -6
===========================================
- Hits 116929 116910 -19
- Misses 46534 46554 +20
Partials 5181 5181
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/jira CORE |
|
Layne could not analyze all changed content. Review the Check Run summary before merging. |
5869339 to
a60fde5
Compare
Proposed changes (including videos or screenshots)
Adds a deprecation warning to the
checkFederationConfigurationmeteor method, following the standardmethodDeprecationLogger.methodpattern.The method belongs to the old Matrix bridge federation stack and was only reachable through the hidden
Federation_Matrix_check_configuration_buttonaction setting, which is being removed in 9.0.0 (#41908). It has no other callers in the codebase and no replacement endpoint.Issue(s)
Steps to test or reproduce
Call the
checkFederationConfigurationmeteor method — the server logs the deprecation warning and increments the deprecation metrics.Further comments
Removal targeted at 9.0.0 alongside the Matrix bridge settings removal (#41908).
Task: CORE-2623
Summary by CodeRabbit