fix: arm64 docker image - #42136
fix: arm64 docker image#42136
Conversation
The Meteor bundle ships build/Release output compiled on the glibc-based CI host. node-gyp-build prefers build/Release over prebuilds/, so that binary shadows the musl one from the same package and fails to load at runtime. `npm install` rebuilt argon2 against musl on amd64 but not on arm64, leaving the arm64 image crashing at boot while the amd64 one started fine. Remove the carried-in build output wherever the package also ships prebuilds, so the correct binary is selected on both architectures. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Looks like this PR is ready to merge! π |
π¦ Changeset detectedLatest commit: 5558837 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: π Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. π Recent review detailsβ° Context from checks skipped due to timeout. (3)
π Additional comments (2)
WalkthroughThe Alpine Docker build removes stale glibc native-module builds so ChangesAlpine native module fix
Priority: β Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Β· Severity of issue fixed: Medium Suggested labels: Suggested reviewers: Merge Risk: βͺ Minimal Β· up to No actionable regression remains established for this Alpine native-module cleanup. π₯ Pre-merge checks | β 5β Passed checks (5 passed)
β¨ Finishing Touches π‘ 1π οΈ Fix failing CI checks π‘
Warning Errors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #42136 +/- ##
===========================================
+ Coverage 69.43% 69.50% +0.06%
===========================================
Files 4315 4315
Lines 177504 177517 +13
Branches 31503 31575 +72
===========================================
+ Hits 123254 123378 +124
+ Misses 49148 49025 -123
- Partials 5102 5114 +12
Flags with carried forward coverage won't be shown. Click here to find out more. π New features to boost your workflow:
|
|
/jira ARCH |
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
Task: ARCH-2423