fix(fuselage): Select's hidden select causing a layout shift - #1980
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ebbe6ba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
ricardogarim
marked this pull request as ready for review
May 20, 2026 19:49
ricardogarim
changed the title
ricardogarim
force-pushed
the
fix/accordion-panel-scroll-height
branch
from
May 22, 2026 11:47
cfec21c to
2761eb3
Compare
ricardogarim
force-pushed
the
fix/accordion-panel-scroll-height
branch
from
May 22, 2026 15:34
2761eb3 to
ebbe6ba
Compare
tassoevan
force-pushed
the
fix/accordion-panel-scroll-height
branch
from
May 22, 2026 20:27
79a3de0 to
ebbe6ba
Compare
tassoevan
approved these changes
May 22, 2026
tassoevan
changed the title
Select's hidden select causing a layout shift
tassoevan
changed the title
Select's hidden select causing a layout shiftSelect's hidden select causing a layout shift
Merged
| '@rocket.chat/fuselage': patch | ||
| --- | ||
|
|
||
| Fixed `Select` inflating ancestor scrollHeight inside non-positioned containers (collapsed `Accordion`, `Modal`, `Field`, etc.). Regression from 0.77.0 (#1939). |
Contributor
There was a problem hiding this comment.
changeset content should be the same as the PR title 😢
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Wrap
HiddenSelectin a positionedBoxinsideSelectAria, so its absolute positioning no longer escapes to upstream ancestors and inflates their scroll height.Why
react-aria's
HiddenSelectis a 1×1 pxposition: absoluteelement (used for browser autofill and native form submission). In #1939 it was moved out ofSelectTriggerto fix an a11y violation, leaving it with no nearby positioned ancestor. Its position now resolves against the next positioned element upstream — typically theOverlayScrollbarsviewport hundreds of pixels above — anchoring the 1×1 element deep inside that viewport's coordinate space and inflating itsscrollHeight.On Rocket.Chat admin pages (Accounts, OAuth, Layout), with many Selects inside collapsed
Accordionpanels, this surfaces as ~2100px of blank scroll below the content.Fix
Wrap
HiddenSelectin<Box position='relative' size={0}>insideSelectAria.SelectTriggerandPopoverare untouched.Steps to reproduce
/admin/settings/AccountsActual: ~2100px blank area below the last setting.
Expected: Scroll ends at the last item.
Issue(s)
CORE-2202. Regression from #1939.